0

したがって、このハッシュの配列からすべての高校と大学院を取得しようとしています。

"education": [
    {
      "school": {
        "id": "110703012290674", 
        "name": "Kunskapsgymnasiet Malmö"
      }, 
      "year": {
        "id": "136328419721520", 
        "name": "2009"
      }, 
      "type": "High School"
    }, 
    {
      "school": {
        "id": "112812485399398", 
        "name": "Malmö University"
      }, 
      "year": {
        "id": "118118634930920", 
        "name": "2012"
      }, 
      "concentration": [
        {
          "id": "104076956295773", 
          "name": "Computer Science"
        }
      ], 
      "type": "Graduate School", 
      "classes": [
        {
          "id": "165093923542525", 
          "name": "Programmering", 
          "description": "Kursen fokuserar på metoder och tekniker vid utveckling av webbapplikationer med hjälp av HTML5."
        }
      ]
    }
  ],

このような：

if auth["extra"]["raw_info"]["education"]  

        # hash/array element 0
        if auth["extra"]["raw_info"]["education"][0]["type"] == "High School" 
          user.highschool_name = auth["extra"]["raw_info"]["education"][0]["school"]["name"] if (!auth["extra"].blank? && !auth["extra"]["raw_info"]["education"][0]["school"].blank?)
          user.highschool_year = auth["extra"]["raw_info"]["education"][0]["year"]["name"] if (!auth["extra"].blank? && !auth["extra"]["raw_info"]["education"][0]["year"].blank?)

        elsif auth["extra"]["raw_info"]["education"][0]["type"] == "Graduate School"
          user.graduateschool_name = auth["extra"]["raw_info"]["education"][0]["school"]["name"] if (!auth["extra"].blank? && !auth["extra"]["raw_info"]["education"][0]["school"].blank?)
          user.graduateschool_year = auth["extra"]["raw_info"]["education"][0]["year"]["name"] if (!auth["extra"].blank? && !auth["extra"]["raw_info"]["education"][0]["year"].blank?)
        end

        # hash/array element 1 
        if auth["extra"]["raw_info"]["education"][1]["type"] == "High School"
          user.highschool_name = auth["extra"]["raw_info"]["education"][1]["school"]["name"] if (!auth["extra"].blank? && !auth["extra"]["raw_info"]["education"][1]["school"].blank?)
          user.highschool_year = auth["extra"]["raw_info"]["education"][1]["year"]["name"] if (!auth["extra"].blank? && !auth["extra"]["raw_info"]["education"][1]["year"].blank?)

        elsif auth["extra"]["raw_info"]["education"][1]["type"] == "Graduate School"        
          user.graduateschool_name = auth["extra"]["raw_info"]["education"][1]["school"]["name"] if (!auth["extra"].blank? && !auth["extra"]["raw_info"]["education"][1]["school"].blank?)
          user.graduateschool_year = auth["extra"]["raw_info"]["education"][1]["year"]["name"] if (!auth["extra"].blank? && !auth["extra"]["raw_info"]["education"][1]["year"].blank?)
        end
      end

ある種のループのように、より効率的な方法はありますか? 素晴らしいアイデアはありますか？

4

1 に答える 1

2

はい、まさに、ループを使用する必要があります。あなたはこのようなものが欲しいようです：

if edu = auth["extra"]["raw_info"]["education"]  
  edu.each do |e|
    if e["type"] == "High School" 
      user.highschool_name = e["school"]["name"] if (!auth["extra"].blank? && !e["school"].blank?)
      user.highschool_year = e["year"]["name"] if (!auth["extra"].blank? && !e["year"].blank?)
    elsif e["type"] == "Graduate School"
      user.graduateschool_name = e["school"]["name"] if (!auth["extra"].blank? && !e["school"].blank?)
      user.graduateschool_year = e["year"]["name"] if (!auth["extra"].blank? && !e["year"].blank?)
    end
  end
end

アップデート

さて、これはさらに単純なバージョンです（toklandの提案に基づく）。

if (auth["extra"]["raw_info"]["education"] || []).each do |e|

  nameprop, yearprop = if e["type"] == "High School"
    [:highschool_name, :highschool_year]
  elsif e["type"] == "Graduate School"
    [:graduateschool_name, :graduateschool_year]
  end

  user.send("#{nameprop}=", e["school"]["name"]) if !e["school"].blank?
  user.send("#{yearprop}=", e["year"]["name"]) if !e["year"].blank?
end
于 2012-07-09T19:54:49.783 に答える