0

従業員店を作っています。employeeStoreの削除機能は機能しません。従業員を削除する代わりに、誰もが何か悪いことを見ることができません。

これが私のコードです:メイン

case 3:
                System.out.println("Delete by Name.");
                Employee employeeDelete = MenuMethods.userInputByName();
                Store.searchByName(employeeDelete.getEmployeeName());
                System.out.println("Your choice is: "+ employeeDelete);
                Store.remove(employeeDelete);
                break;

削除方法

// ---------------------------------------------------------------------------------------
// Name: Remove.
// ---------------------------------------------------------------------------------------
public Employee remove(Employee key) {
    // Remove the Employee by name.
    if (map.containsKey(key))
        return map.remove(key); // if its there remove and return
    else
        return null; // if its not there return 0x00000000 address
}

メニューメソッド

//---------------------------------------------------------------------------------------
//  Name:           Imports.
//  Description:    To allow the use of different Java classes.
//---------------------------------------------------------------------------------------
import java.util.Scanner;
//---------------------------------------------------------------------------------------
public class MenuMethods 
{
    private static Scanner keyboard = new Scanner(System.in);
//---------------------------------------------------------------------------------------
//  Methods for the Company Application menu.
//---------------------------------------------------------------------------------------

//---------------------------------------------------------------------------------------
//  Name:           getMenuChoice.
//  Description:    Method for validating the choice.
//---------------------------------------------------------------------------------------
    public static int getMenuChoice(String menuString, int limit,String prompt, String errorMessage) 
    {
        System.out.println(menuString);
        int choice = inputAndValidateInt(1, limit, prompt, errorMessage);
        return choice;
    }

//---------------------------------------------------------------------------------------
//  Name:        inputAndValidateInt.
//  Description: This method is used in the getMenuChoice method.
//---------------------------------------------------------------------------------------
    public static int inputAndValidateInt(int min, int max, String prompt,String errorMessage) 
    {
        int number;
        boolean valid;
        do 
        {
            System.out.print(prompt);
            number = keyboard.nextInt();
            valid = number <= max && number >= min;
            if (!valid) 
            {
                System.out.println(errorMessage);
            }
        } while (!valid);
        return number;
    }

//---------------------------------------------------------------------------------------
//  Name:        userInput
//  Description: This method is used in the MainApp to give the user capability to enter
//               the details when adding details of an employee into the store.
//---------------------------------------------------------------------------------------
    public static Employee userInput() 
    {
        String temp = keyboard.nextLine();
        Employee e = null;
        System.out.println("Please enter the Employee Name:");
        String employeeName = keyboard.nextLine();
        System.out.println("Please enter the Employee ID:");
        int employeeId = keyboard.nextInt();
        temp = keyboard.nextLine();
        System.out.println("Please enter the Employee E-mail address:");
        String employeeEmail = keyboard.nextLine();
        return e = new Employee(employeeName, employeeId, employeeEmail);

    }

//---------------------------------------------------------------------------------------
//  Name:        userInputByName.
//  Description: This method is used in the MainApp to give the user capability to search by name.
//---------------------------------------------------------------------------------------
    public static Employee userInputByName() 
    {
        // String temp is for some reason needed. If it is not included
        // The code will not execute properly.
        String temp = keyboard.nextLine();
        Employee e = null;
        System.out.println("Please enter the Employee Name:");
        String employeeName = keyboard.nextLine();

        return e = new Employee(employeeName);

    }

//---------------------------------------------------------------------------------------
//  Name:        userInputByEmail
//  Description: This method is used in the MainApp to give the user capability to search by email.
//---------------------------------------------------------------------------------------
    public static String userInputByEmail() 
    {
        // String temp is for some reason needed. If it is not included
        // The code will not execute properly.
        String temp = keyboard.nextLine();
        Employee e = null;
        System.out.println("Please enter the Employee Email:");
        String employeeEmail = keyboard.nextLine();
        // This can use the employeeName's constructor because java accepts the
        // parameters instead
        // of the name's.
        return employeeEmail;

    }
//---------------------------------------------------------------------------------------

}

従業員

//---------------------------------------------------------------------------------------
//  Employee class.
//---------------------------------------------------------------------------------------
public class Employee
{
//---------------------------------------------------------------------------------------
//  Variables to be used in the employee store.
//---------------------------------------------------------------------------------------
    private String employeeName;
    private int employeeId;
    private String employeeEmail;
//---------------------------------------------------------------------------------------
//  Name:        Constructors.
//  Description:
//---------------------------------------------------------------------------------------
    public Employee(String employeeName, int employeeId, String employeeEmail) 
    {
        this.employeeName = employeeName;
        this.employeeId = employeeId;
        this.employeeEmail = employeeEmail;
    }
//---------------------------------------------------------------------------------------
//  Overloading the constructor for the use with userInputByName method.
//---------------------------------------------------------------------------------------
    public Employee(String employeeName) 
    {
        this.employeeName = employeeName;
    }
//---------------------------------------------------------------------------------------
//  Name:   Getters.
//---------------------------------------------------------------------------------------
    public String getEmployeeEmail() 
    {
        return employeeEmail;
    }

    public String getEmployeeName() 
    {
        return employeeName;
    }
    public int getEmployeeId() 
    {
        return employeeId;
    }
//---------------------------------------------------------------------------------------
//  Name:   Setters.
//---------------------------------------------------------------------------------------
    public void setEmployeeEmail(String employeeEmail) 
    {
        this.employeeEmail = employeeEmail;
    }
    public void setEmployeeName(String employeeName) 
    {
        this.employeeName = employeeName;
    }
    public void setEmployeeId(int employeeId)
    {
        this.employeeId = employeeId;
    }

//---------------------------------------------------------------------------------------
//  Name:   toString.
//---------------------------------------------------------------------------------------
    public String toString() 
    {
        return "\t\t\tEmployee\n" +
                "********************************************************************\n"+
                "Employee Name: "+ employeeName +"\n"+ 
                "Employee Id: " + employeeId +"\n"+  
                "Employee Email: " + employeeEmail;
    }
//---------------------------------------------------------------------------------------
}
4

3 に答える 3

3

この方法

public static Employee userInputByName

新しい を作成していEmployeeます。(それはまた、それをローカル変数に無意味に割り当てています...ここでのコードスタイルは本当に奇妙です-への無関係な呼び出しもそうnextLine()です。)

をオーバーライドequalsしてhashCodeでない限り、新しいオブジェクトが内の既存のオブジェクトと等しいとEmployeeは見なされません。残念ながら、クラスは表示されていませんが、おそらく、同じ名前の従業員を同等と比較する(そして同じハッシュコードを与える)ことを目的としています。 EmployeeHashMapEmployee

于 2012-07-23T15:33:38.670 に答える
1

あなたがする必要があるのは

public Employee remove(Employee key) {
    // Remove the Employee by name.
    return map.remove(key); // if its there remove and return
}

この問題の最も一般的な原因は、hashCodeとequalsのいずれかが正しくないか、一致しないか、可変フィールドに依存していることです。

于 2012-07-23T15:33:54.420 に答える
1

古典的:オブジェクトにequals()とhashcode()がない可能性がありEmployeeます。また、employee.idのような単純なキーをマップに使用することも検討する必要があります。現在のように、EmployeeMapはEmployeeSetとしてモデル化する方が適切です。

コードをさらに詳しく見てみると、従業員オブジェクトのインデックスとして複数のマップを作成することをお勧めします。

Map<Integer, Employee> employeeById
Map<String, Employee> employeeByEmail;
MultiMap<String, Employee> employeeByName; 

最後の行に提案されているcom.google.common.collect.Multimapに注意してください。これは、同じJohnDoe名を共有する複数の従業員参照を保持する可能性があるためです。

于 2012-07-23T15:44:53.490 に答える