0

独学でプログラミングを学び、簡単なワット数計算機を作ることにしました。州ごとに (平均) 価格/KWh が異なります。私の問題は、コードの 34 行目から始まります。curr->next が null になることはありません。

私は何を間違っていますか？

#include<stdio.h>
#include<stdlib.h>
#include<string.h>


float calculate(float w, float cents, float h);

struct states 
{
    char *name;
    char *price;
    struct states *next;
};

int main()
{
    float watts,hours,cents;
    int a = 0;
    struct states *curr, dict[52];
    char st_ab[52][3] = {"ID","ND","WA","AR","UT","LA","WY","SD","NE","KY","WV","OK","OR","MT","MS","TN","IN","NC","MS","IA","KS","VA","NM","MN","SC","AZ","GA","AL","CO","OH","TX","IL","FL","NV","MI","WI","PA","MD","DC","DE","MA","RI","CA","ME","VT","NJ","NH","AK","CT","NY","HI"};
    char st_pr[52][5] = {"8.0","8.1","8.2","8.7","8.8","8.9","8.9","9.0","9.0","9.0","9.2","9.2","9.4","9.6","9.7","9.8","10.0","10.2","10.3","10.5","10.5","10.5","10.7","10.9","11.0","11.1","11.1","11.1","11.2","11.2","11.3","11.7","11.7","11.7","13.0","13.0","13.2","13.7","13.7","13.7","14.8","14.9","15.2","15.5","16.1","16.3","16.5","17.5","18.1","18.1","33.2"};
    char state[2];

    for(a=0;a<=52;a++)
    {
        memset(&dict[a],0,sizeof(struct states)); /* zero out structure */
        if(a==52)
        {
            break;  /* if this is the last struct, leave it NULL so we can loop through linked list */
        }
        dict[a].next=&dict[a+1];        
    }

    for(curr = dict;curr ->next != NULL;curr = curr->next)  /* fill our list with state abbr. and cost/KWh */
    {
        curr->name = st_ab[a];
        curr->price = st_pr[a];
        a++;
    }

    puts("Dictionary loaded!");
    printf(" Two letter state code: ");                 /* get info from user */
    scanf("%s",state);

    printf(" Wattage of appliance: ");
    scanf("%f",&watts);

    printf(" Hours of use per day: ");
    scanf("%f",&hours);

    for(curr = dict; curr->next != NULL; curr=curr->next)
    {
        printf("comparing %s with %s\n", curr->name,state);  /* search for our state, set cents respectively */
        if((strcmp(curr->name,state)) == 0)
        {
            printf("State found! -- %s\n",state);
            cents=atof(curr->price);
            printf("%f cents\n",cents);
            break;
        } else {
            printf("state didn't match\n");
            continue;
        }
    }

    printf("\nAverage cost per day: %.2f\n",  calculate(watts,cents,hours));
    printf("Average cost per year: %.2f\n\n", (calculate(watts,cents,hours)) * 365);    

    return 0;

}

float calculate(float w, float c, float h)
{   
    float kwh = (w/1000) * h;
    float cos = kwh*(c/100);
    return(cos);
}
4

2 に答える 2

2

問題は

dict[a].next = &dict[a+1];

&dict[a+1]C 標準では、配列の末尾を 1 つ過ぎても NULL にならないことが保証されています。これにより、次のループがリストの最後を超えてしまい、未定義の動作が発生します (プログラムは何でもする可能性があります)。最初のループの後、

dict[51].next = NULL;

リンクされたリストを終了します。

EDIT :for(a=0;a<=52;a++)実際には、配列の末尾を 2 要素通過するため、動作は 2 か所で未定義です。これを修正するには、までループする必要がありますa<52。

于 2013-03-28T14:43:57.907 に答える
0

「curr->next が null になることはありません」 - では、停止条件が curr->next で null に等しい場合、for ループが停止することをどのように期待しますか?

于 2013-03-28T14:43:43.990 に答える