java - この行の NullPointerException if (action.equalsIgnoreCase("delete"))

Question

protected void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
    String forward="";
    String action = request.getParameter("action");

    if (action.equalsIgnoreCase("delete")){
        int userId = Integer.parseInt(request.getParameter("userId"));
        dao.deleteUser(userId);
        forward = LIST_USER;
        request.setAttribute("users", dao.getAllUsers());    
    } else if (action.equalsIgnoreCase("edit")){
        forward = INSERT_OR_EDIT;
        int userId = Integer.parseInt(request.getParameter("userId"));
        User user = dao.getUserById(userId);
        request.setAttribute("user", user);
    } else if (action.equalsIgnoreCase("listUser")){
        forward = LIST_USER;
        request.setAttribute("users", dao.getAllUsers());
    } else {
        forward = INSERT_OR_EDIT;
    }

    RequestDispatcher view = request.getRequestDispatcher(forward);
    view.forward(request, response);
}}

Answer 1

に変更すると、定数部分を主なオブジェクトとして作成し、変数部分が等しいかどうかを確認できます

"delete".equalsIgnoreCase(action)

Answer 2

request.getParameter("action");ここではnullです

だから使う

 if (action!=null && action.equalsIgnoreCase("delete")){
       int userId = Integer.parseInt(request.getParameter("userId"));
    dao.deleteUser(userId);
    forward = LIST_USER;
    request.setAttribute("users", dao.getAllUsers());    
} else if (action!=null && action.equalsIgnoreCase("edit")){
    forward = INSERT_OR_EDIT;
    int userId = Integer.parseInt(request.getParameter("userId"));
    User user = dao.getUserById(userId);
    request.setAttribute("user", user);
} else if (action!=null && action.equalsIgnoreCase("listUser")){
    forward = LIST_USER;
    request.setAttribute("users", dao.getAllUsers());
} else {
    forward = INSERT_OR_EDIT;
}

Answer 3

私はArun P Johnyのソリューションを好むかもしれませんが、このヘルパーメソッドも便利かもしれません:

public String getParameter(HttpServletRequest request, String parameterName, String defaultvalue) {
    String result = request.getParameter(parameterName);

    return (result != null) ? result : defaultValue;
}

そして電話する

String action = getParameter(request, "action", "");

Answer 4

使ってみて

 String action = request.getParameter("action")+"";

したがって、他のすべてのチェックでは NPE が得られません。