1

私のコードには再帰があります。再度プレイしたい場合は対象外となります。ループの前後に console2 を配置することはできません。開始時にもう一度再生するかどうかを尋ねるのは意味がありません。私の初心者用コードにはおそらく多くの欠陥があるので、遠慮なく指摘してください。ありがとう。

これまでのコードは次のとおりです—再帰を使用します。

import java.util.*;
import java.awt.*;
import java.io.*;


public class RockPaperScissors {


    public static int count = 0;

    public static void main(String[] args) {

            execute(); 
    }


    public static void execute(){       

        System.out.println("This program will allow you to play \n\"Rock, Paper, Scissors\" against a computer.");
        System.out.println();
        System.out.println("Enter 'r' for Rock, 'p' for Paper, or s for Scissors.");
        System.out.println("Enter 'w' to have an insta-win for that round. Enter '-1' at anytime to exit program.");

        String info = userInput();
        int value = guessCode();
        decideOutcome(value, info);
        again();
        }


        public static String userInput() {
        Scanner console = new Scanner (System.in);  
        String s = console.next();
        return s;
    }

        public static int guessCode() {
        Random r = new Random ();   
        return (r.nextInt(3)+1); // Random integer between 1 and 3;
    }

    public static void decideOutcome(int i, String j) {

        try {
            PrintStream output = new PrintStream(new FileOutputStream("records.txt", true));

            if (j.equalsIgnoreCase("rock")|| j.equalsIgnoreCase("r")) {
                count++;
                switch (i){
                    case 1:
                        System.out.println("You've won! Computer picked scissors.");
                        output.println(count + " Win ");
                        break;
                    case 2:
                        System.out.println("You've tied.... Computer also picked rock.");
                        output.println(count + " Tie ");
                        break;
                    case 3:
                        System.out.println("You've lost. Computer picked paper.");
                        output.println(count + " Loss ");
                        break;
                    }           
            } else if (j.equalsIgnoreCase("paper")|| j.equalsIgnoreCase("p")) {
                count++;
                switch (i){
                    case 1:
                        System.out.println("You've lost; Computer picked scissors.");
                        output.println(count + " Loss ");
                        break;
                    case 2:
                        System.out.println("You've won! Computer picked rock.");
                        output.println(count + " Win ");
                        break;
                    case 3:
                        System.out.println("You've tied.... Computer also picked paper.");
                        output.println(count + " Tie ");
                        break;
                    }
            } else if (j.equalsIgnoreCase("scissors")|| j.equalsIgnoreCase("s")) {
                count++;
                switch (i){
                    case 1:
                        System.out.println("You've tied.... Computer picked scissors.");
                        output.println(count + " Tie ");
                        break;
                    case 2:
                        System.out.println("You've lost; Computer picked rock.");
                        output.println(count + " Loss ");
                        break;
                    case 3:
                        System.out.println("You've won! Computer also picked paper.");
                        output.println(count + " Win ");
                        break;
                    }
            } else if (j.equalsIgnoreCase("w")) {
                count++;
                System.out.println("You've effortlessly defeated the computer!");
                output.println(count + " Win ");
            } else if (j.equals("-1")) {
                System.out.println("Thanks for playing!"); // need to find way to reach end.

                if (count == 1) { // If the user terminates after the first match.
                    System.out.println("You've played a single match.");        
                } else if (count > 1) { // Anything more than 1 match played upon termination.
                    System.out.println("You've played " + count + " matches total.");   
                } else { // This is for exceptions when user inputs gibberish for their sign and then 'no' for the second input.
                    System.out.println("No matches were played.");  
            }           
                System.out.println("Good Bye!");
                System.exit(0);
            } else {
                System.out.println("You didn't input the right thing.");
            }
        } catch (FileNotFoundException e) {
                System.out.println("File was not found; try again");
        }
    }

    public static void again() {
            System.out.println("Do you want to play again? (Type in 'y' for Yes or 'n' for No.)");

            Scanner console2 = new Scanner (System.in);

            String t = console2.next();

            while (t.equalsIgnoreCase("yes")||t.equalsIgnoreCase("y")) {
                System.out.println();
                System.out.println();
                execute(); // 
            }  
            if (t.equalsIgnoreCase("no") || t.equalsIgnoreCase("n") || t.equals("-1")) {
                System.out.println("Hope you had fun! I'm sure I've had just as much fun with making this program! Good Bye!");         

                if (count == 1) { // If the user terminates after the first match.
                        System.out.println("You've played a single match.");        
                } else if (count > 1) { // Anything more than 1 match played upon termination.
                        System.out.println("You've played " + count + " matches total.");   
                } else { // This is for exceptions when user inputs gibberish for their sign and then 'no' for the second input.
                        System.out.println("No matches were played.");              
                }   
                System.exit(0);

            } else { // If the user doesn't input 'yes' or 'no.'
                System.out.println("Not the proper response, but it's assumed that you don't want to continue.");   
                if (count == 1) { // If the user terminates after the first match.
                    System.out.println("You've completed a single match."); 
                } else if (count >= 2) { // Anything more than 1 match played upon termination.
                    System.out.println("You've completed " + count + " matches total.");
                } else { // The user haphazardly messes up both inputs.
                    System.out.println("No matches were finished.");
                }
                System.exit(0);
            }
        }
}
4

3 に答える 3

0

簡単な変更は、メイン メソッドの do-while でありexecute、 while の結果 (単純なブール値である可能性があります) をテストしてagain、ユーザーが続行するかどうかを確認します。

ところで、私の意見executeでは、唯一の public メソッドであるべきであり、すべてを持つ理由はありませんpublic staticcountはただの候補ですprivate。そうしないと、クラスに再度アクセスしても、たとえば、初期値が 0 であることが保証されません。

于 2013-05-26T19:21:19.297 に答える
0

新しいブール変数を作成してkeepPlaying初期化しtrue、プレイヤーがゲームを終了したい場合は false に設定します。

次に、メイン メソッドで次のように言います。

public static void main(String[] args) {

System.out.println("This program will allow you to play \n\"Rock, Paper, Scissors\" against a computer.");
    System.out.println();
    System.out.println("Enter 'r' for Rock, 'p' for Paper, or s for Scissors.");
    System.out.println("Enter 'w' to have an insta-win for that round. Enter '-1' at anytime to exit program.");

    while (keepPlaying == true) {
        again();
    }
}

入力コードをagain()メソッドの先頭に配置します。

private static void again() { // Maybe rename to play()?
    String info = userInput();
    int value = guessCode();
    decideOutcome(value, info);
    .....
}

その後、必要はありませんexecute()。別の回答が示唆したように、メソッドと変数は、別のクラスで必要とされない限り、公開する必要があります。

于 2013-05-26T19:14:57.030 に答える