次のカスタム clean() メソッドを持つフォームがあります。
def clean(self):
cleaned_data = self.cleaned_data
event_date = cleaned_data.get("event_date")
location = cleaned_data.get("location")
if event_date and location:
cleaned_data['relevance'] = True
else:
cleaned_data['relevance'] = False
raise forms.ValidationError("You need to supply at least Event and Location information")
return cleaned_data
エラーを修正できるように、ユーザーに ValidationError を表示したいと思います。
ただし、このフォームを作成するフォームセットには、次のように extra=0 が設定されています。
CodingFormSet = formset_factory(CodingForm, extra=0)
if request.method=='POST':
[...]
elif "coding_form_save" in request.POST:
formset = CodingFormSet(request.POST, prefix="coding_form")
process_form(formset, request, current_page, paginator)
update_location_set(formset, coded_events, location_queryset)
redirect_to = "?page=%s" % current_page
return HttpResponseRedirect(redirect_to)
def process_form(formset, request, current_page, paginator):
if formset.is_valid():
for form in formset.forms:
form = form.cleaned_data
if form["relevance"] == False:
pass
elif form["relevance"] == True:
event_form = EventRecordForm()
event = event_form.save(commit=False)
event.article = paginator.page(current_page).object_list[0]
event.coder = request.user
event.last_updated = datetime.datetime.today()
event.event_date = form["event_date"]
event.location = form["location"]
event.actors = form["actors"]
event.num_participants = form["num_participants"]
event.issue = form["issue"]
event.side = form["side"]
event.scope = form["scope"]
event.part_violence = form["part_violence"]
event.sec_engagement = form["sec_engagement"]
event.save()
##### Add info on who worked on the article when
history_form = ArticleHistoryForm()
article_history = history_form.save(commit=False)
article_history.article = paginator.page(current_page).object_list[0]
article_history.coder = request.user
article_history.last_updated = datetime.datetime.now()
article_history.save()
extra=0 のままにして、ユーザー検証エラーを表示する方法はありますか?
更新: @Alasdair のおかげで、フォームが有効な場合にのみリダイレクトすることで、検証エラーを表示できるようになりました。コードは次のようになります。
def assignment(request, pk):
"""View for each assignment"""
if request.user.is_authenticated():
#### Get correct articles
assignment = get_object_or_404(Assignment, pk=pk)
country = assignment.country.cowcode
start_date = assignment.start_date
end_date = assignment.end_date
articles = Article.objects.filter(cowcode=country).filter(pubdate__range=(start_date,end_date))
#### Pagination ####
paginator = Paginator(articles, 1)
page = request.GET.get('page')
try:
articles = paginator.page(page)
except PageNotAnInteger:
articles = paginator.page(1)
except EmptyPage:
articles = paginator(page(paginator.num_pages))
# Check if on first page and enable redirect
if page is None:
current_page = 1
else:
current_page = page
redirect_to = "?page=%s" % current_page
##### Show already created events on the page
current_article = paginator.page(current_page).object_list[0]
EventFormSet = modelformset_factory(EventRecord, can_delete=True, exclude=('coder','article','url','last_updated'), extra=0)
event_queryset = EventRecord.objects.filter(article__id=current_article.id).filter(coder=request.user.id)
coded_events = EventFormSet(queryset=event_queryset, prefix="event_form")
last_updated = ArticleHistory.objects.filter(coder=request.user.id).filter(article__id=current_article.id).order_by('-pk')[0]
##### Create Forms
CodingFormSet = formset_factory(CodingForm, extra=0)
###### Get correct locations
location_queryset = Geonames.objects.filter(cowcode=country).order_by('name')
if request.method=='POST':
##### Check if coder wants to go to next page or stay
if "coding_form_next" in request.POST:
formset = CodingFormSet(request.POST, prefix="coding_form")
process_form(formset, request, current_page, paginator, next_article, coded_events, location_queryset)
update_location_set(formset, coded_events, location_queryset)
#current_page = int(current_page) + 1
#redirect_to = "?page=%s" % current_page
#return HttpResponseRedirect(redirect_to)
elif "coding_form_save" in request.POST:
formset = CodingFormSet(request.POST, prefix="coding_form")
process_form(CodingFormSet, formset, request, current_page, paginator, next_article, coded_events, location_queryset)
update_location_set(formset, coded_events, location_queryset)
#redirect_to = "?page=%s" % current_page
#return HttpResponseRedirect(redirect_to)
elif 'add_event' in request.POST:
cp = request.POST.copy()
cp['coding_form-TOTAL_FORMS'] = int(cp['coding_form-TOTAL_FORMS'])+ 1
formset = CodingFormSet(cp,prefix='coding_form')
update_location_set(formset, coded_events, location_queryset)
elif 'save_changes' in request.POST:
formset = CodingFormSet(prefix="coding_form")
changed_events = EventFormSet(request.POST, prefix="event_form")
instances = changed_events.save()
update_location_set(formset, coded_events, location_queryset)
history_form = ArticleHistoryForm()
article_history = history_form.save(commit=False)
article_history.article = paginator.page(current_page).object_list[0]
article_history.coder = request.user
article_history.last_updated = datetime.datetime.now()
article_history.save()
EventFormSet = modelformset_factory(EventRecord, can_delete=True, exclude=('coder','article','url','last_updated'), extra=0)
event_queryset = EventRecord.objects.filter(article__id=current_article.id).filter(coder=request.user.id)
coded_events = EventFormSet(queryset=event_queryset, prefix="event_form")
else:
formset = CodingFormSet(request.POST or None,prefix="coding_form")
update_location_set(formset, coded_events, location_queryset)
else:
print ERROR
return render(request, 'coding/assignment.html',
{'articles':articles,'assignment':assignment,'formset':formset,'coded_events':coded_events,'last_updated':last_updated})
def process_form(CodingFormSet, formset, request, current_page, paginator, next_article, coded_events, location_queryset):
if formset.is_valid():
for form in formset.forms:
form = form.cleaned_data
if form["relevance"] == False:
pass
elif form["relevance"] == True:
event_form = EventRecordForm()
event = event_form.save(commit=False)
event.article = paginator.page(current_page).object_list[0]
event.coder = request.user
event.last_updated = datetime.datetime.today()
event.event_date = form["event_date"]
event.location = form["location"]
event.actors = form["actors"]
event.num_participants = form["num_participants"]
event.issue = form["issue"]
event.side = form["side"]
event.scope = form["scope"]
event.part_violence = form["part_violence"]
event.sec_engagement = form["sec_engagement"]
event.save()
##### Add info on who worked on the article when
history_form = ArticleHistoryForm()
article_history = history_form.save(commit=False)
article_history.article = paginator.page(current_page).object_list[0]
article_history.coder = request.user
article_history.last_updated = datetime.datetime.now()
article_history.save()
redirect_to = "?page=%s" % current_page
return HttpResponseRedirect(redirect_to)
ただし、現在の違いは 3 つの図で最もよく示され
てsaveいます。
今、saveコーダーを叩いた後、
これが見えます：これは、彼が保存をまったく押していないようです。
そして、saveもう一度クリックするか、ページをリロードした
後にのみ、次のように表示されます。
最初の図に戻りたいと思います。ここでは、コーダーはコード化されたイベントを見て、同じ情報を持つ新しいフォームはありません。これは、コードを 2 行ずらして他に何もしなかったために発生したことに注意してください。
どんな助けでも大歓迎です！