2

Web ページを取得しようとするメソッドがあります。何度か取得を試みたいので、何度か再試行するためのラッパーを作成しました。呼び出されたメソッドで、null を返す例外をキャッチして無視します。したがって、最初の試行の後、再試行が行われます。呼び出されたメソッドは次のとおりです。

internal static async Task<string> WebClientAsync(string URI, NetworkCredential Creds = null, Dictionary.FantasySite Site = Dictionary.FantasySite.Other)
{
    if (Creds == null)
    {
        try
        {   //attempt to get the web page
            HttpClient client = new HttpClient(); //create client
            HttpResponseMessage response = await client.GetAsync(URI);  //get response
            response.EnsureSuccessStatusCode(); //ensure the response is good (or throw Exception)
            return await response.Content.ReadAsStringAsync();  //return the string back
        }
        catch (HttpRequestException)
        {
            //MessageBox.Show(string.Format("\nHttpRequestException Caught!\nMessage :{0} for URI {1}.", e.Message, URI));
            return null;  //Catch the exception because we wrapped this and are trying again (null is the indicator it didn't work)
        }
        catch (Exception)
        {
            //MessageBox.Show(string.Format("\nException Caught!\nMessage :{0} for URI {1}.", e.Message, URI)); //TODO - THis hasn't happened, but remove it for production
            return null; //Catch the exception because we wrapped this and are trying again  (null is the indicator it didn't work)
        }
    }

}

すべての再試行後にこれでも失敗する場合は、例外をスローしたいのですが、破棄したのでできません。呼び出し方法はこちら。

internal static async Task<string> WebClientRetryAsync(string URI, NetworkCredential Creds = null, Dictionary.FantasySite Site = Dictionary.FantasySite.Other)
{
    string webPage = null;
    for (int i = 0; i < Dictionary.WEB_PAGE_ATTEMPTS; i++)  //Attempt to get the webpage x times
    {
        System.Diagnostics.Debug.Print(string.Format("WebClientRetryAsync attempt {0} for {1}", i + 1, URI));
        //wait some time before retrying just in case we are too busy
        //Start wait at 0 for first time and multiply with each successive failure to slow down process by multiplying by i squared
        Thread.Sleep(Wait.Next(i * i * Dictionary.RETRY_WAIT_MS));
        webPage = await WebClientAsync(URI, Creds, Site);
        if (webPage != null) { break; } //don't attempt again if success
    }
    /*TODO - If webPage is null we didn't have success and need to throw an exception.  
     * This is done in the calls to this method and should be done here, move code over */
    return webPage;
}

これが悪いアプローチであるかどうか、そして何度も失敗した後にコードをリファクタリングして例外をスローする方法を誰かが提案できますか? 呼び出し元のメソッドに例外を渡して、再試行が完了するまで無視する必要がありますか?

4

1 に答える 1