3

以下のコードを簡素化する方法:

public List<Cwzz_CashFlowItem> AllDataPage(int start, int limit, out int total, string xmbmLike, string xmmcLike)
{
    List<Cwzz_CashFlowItem> ll;
    if (xmbmLike != "" && xmmcLike != "")
    {
        total = _ctx.Cwzz_CashFlowItem
                    .Where(v => v.CashFlowCode.Contains(xmbmLike))
                    .Count(v => v.CashFlowName.Contains(xmmcLike));

        ll = _ctx.Cwzz_CashFlowItem
                 .Where(v => v.CashFlowCode.Contains(xmbmLike))
                 .Where(v => v.CashFlowName.Contains(xmmcLike))
                 .OrderBy(v => v.CashFlowCode).Skip(start).Take(limit).ToList();
    }
    else if (xmbmLike != "" && xmmcLike == "")
    {
        total = _ctx.Cwzz_CashFlowItem
                    .Count(v => v.CashFlowCode.Contains(xmbmLike));

        ll = _ctx.Cwzz_CashFlowItem
                 .Where(v => v.CashFlowCode.Contains(xmbmLike))
                 .OrderBy(v => v.CashFlowCode).Skip(start).Take(limit).ToList();
    }
    else if (xmbmLike == "" && xmmcLike != "")
    {
        total = _ctx.Cwzz_CashFlowItem
                    .Count(v => v.CashFlowName.Contains(xmmcLike));

        ll = _ctx.Cwzz_CashFlowItem
                 .Where(v => v.CashFlowName.Contains(xmmcLike))
                 .OrderBy(v => v.CashFlowCode).Skip(start).Take(limit).ToList();
    }
    else
    {
        total = _ctx.Cwzz_CashFlowItem.Count();

        ll = _ctx.Cwzz_CashFlowItem
                 .OrderBy(v => v.CashFlowCode)
                 .Skip(start).Take(limit).ToList();
    }
    return ll;
}

2 つではなく、より多くの条件がある場合、if-else はより複雑になるため、上記のコードを単純化する方法。

4

1 に答える 1

3

Linq 式は連鎖できます。List<> への時期尚早な強制を避けてください。

 public IQueryable<Cwzz_CashFlowItem> AllDataPage(...) {
    IQueryable<Cwzz_CashFlowItem> ll =  _ctx.Cwzz_CashFlowItem;

    if (xmbmLike != "")
    {
      ll = ll.Where(v => v.CashFlowCode.Contains(xmbmLike));
    }

    if (xmcmLike != "")
    {
      ll = ll.Where(v => v.CashFlowCode.Contains(xmcmLike));
    }

    return ll.OrderBy(v => v.CashFlowCode).Skip(start).Take(limit);
   }

out Count を返すことは演習として残します。

于 2013-11-04T05:57:00.397 に答える