3

I am trying to detect is a specific date is within the last 7 days (within the last week). I have found a method to do that, but its eating my performance in a tableview (chat controller).

The code is posted below, and i know it can be done a LOT better, but i am running out of ideas. Does somebody have better approach? thanks!

The code:

NSDate *date = [[_messages objectAtIndex:indexPath.row] date];
NSString *lastMessageDateString = [[[NVDate alloc] initUsingDate:date] stringValueWithFormat:@"dd/MM/yy"];
NSString *todayDateString = [[[NVDate alloc] initUsingToday] stringValueWithFormat:@"dd/MM/yy"];
NSString *yesterdayDateString = [[[[NVDate alloc] initUsingToday] previousDay] stringValueWithFormat:@"dd/MM/yy"];
NSString *earlier2DaysDateString = [[[[NVDate alloc] initUsingToday] previousDays:2] stringValueWithFormat:@"dd/MM/yy"];
NSString *earlier3DaysDateString = [[[[NVDate alloc] initUsingToday] previousDays:3] stringValueWithFormat:@"dd/MM/yy"];
NSString *earlier4DaysDateString = [[[[NVDate alloc] initUsingToday] previousDays:4] stringValueWithFormat:@"dd/MM/yy"];
NSString *earlier5DaysDateString = [[[[NVDate alloc] initUsingToday] previousDays:5] stringValueWithFormat:@"dd/MM/yy"];
NSString *earlier6DaysDateString = [[[[NVDate alloc] initUsingToday] previousDays:6] stringValueWithFormat:@"dd/MM/yy"];
NSString *earlier7DaysDateString = [[[[NVDate alloc] initUsingToday] previousDays:7] stringValueWithFormat:@"dd/MM/yy"];
//return the time of the message since it is today
if ([lastMessageDateString isEqualToString:todayDateString]) {
    return [SAD.myE.timeFormat stringFromDate:date];
}
//return the string "yesterday" of the message since it is yesterday
else if ([lastMessageDateString isEqualToString:yesterdayDateString]) {
    return @"Yesterday";
}
//return the string of the actual day of the message since it is within last 7 days
else if ([lastMessageDateString isEqualToString:earlier2DaysDateString] ||
         [lastMessageDateString isEqualToString:earlier3DaysDateString] ||
         [lastMessageDateString isEqualToString:earlier4DaysDateString] ||
         [lastMessageDateString isEqualToString:earlier5DaysDateString] ||
         [lastMessageDateString isEqualToString:earlier6DaysDateString] ||
         [lastMessageDateString isEqualToString:earlier7DaysDateString]) {
    return [SAD.myE.dayFormat stringFromDate:date];
}
//return the string date since the message is olf
else {
    return [SAD.myE.dateFormat stringFromDate:date];
}

EDIT Thanks to @vikingosegundo i have tried to use his solution to implement this solution. He since then made a category that made it even easier that i will try and implement now. Just for the curious ones:

- (NSString *)stringForDate:(NSDate *)date {
NSDate *now = [NSDate date];  // now
NSDate *today;
[[NSCalendar currentCalendar] rangeOfUnit:NSDayCalendarUnit // beginning of this day
                                startDate:&today // save it here
                                 interval:NULL
                                  forDate:now];

NSDateComponents *comp = [[NSDateComponents alloc] init];
comp.day = 0;
NSDate * theDayToday = [[NSCalendar currentCalendar] dateByAddingComponents:comp toDate:today options:0];
if ([date compare:theDayToday] == NSOrderedDescending) {
    return @"today";
}

comp.day = -1;
NSDate * yesterday = [[NSCalendar currentCalendar] dateByAddingComponents:comp toDate:today options:0];
if ([date compare:yesterday] == NSOrderedDescending) {
    return @"yesterday";
}

comp.day = -7;      // lets go 7 days back from today
NSDate * oneWeekBefore = [[NSCalendar currentCalendar] dateByAddingComponents:comp toDate:today options:0];
if ([date compare:oneWeekBefore] == NSOrderedDescending) {
    return @"within 7 days";
} else {
return @"before 7 days";
}
}
4

1 に答える 1

5
-(BOOL) dayOccuredDuringLast7Days
{

    NSDate *now = [NSDate date];  // now
    NSDate *today;
    [[NSCalendar currentCalendar] rangeOfUnit:NSDayCalendarUnit // beginning of this day
                                    startDate:&today // save it here
                                     interval:NULL
                                      forDate:now];

    NSDateComponents *comp = [[NSDateComponents alloc] init];
    comp.day = -7;      // lets go 7 days back from today
    NSDate * oneWeekBefore = [[NSCalendar currentCalendar] dateByAddingComponents:comp 
                                                                           toDate:today 
                                                                          options:0];


    if ([self compare: oneWeekBefore] == NSOrderedDescending) {

        if ( [self compare:today] == NSOrderedAscending ) { // or now?
            return YES;
        }
    }
    return NO;
}

過去 7 日間と昨日の完全なコマンド ラインの例。NSDate のカテゴリとして

#import <Foundation/Foundation.h>



@interface NSDate (ExtendedComparions)
-(BOOL) dayOccuredDuringLast7Days;
-(BOOL) dayWasYesterday;
@end

@implementation NSDate (ExtendedComparions)


-(BOOL) _occuredDaysBeforeToday:(NSUInteger) nDaysBefore
{
    NSDate *now = [NSDate date];  // now
    NSDate *today;
    [[NSCalendar currentCalendar] rangeOfUnit:NSDayCalendarUnit // beginning of this day
                                    startDate:&today // save it here
                                     interval:NULL
                                      forDate:now];

    NSDateComponents *comp = [[NSDateComponents alloc] init];
    comp.day = -nDaysBefore;      // lets go N days back from today
    NSDate * before = [[NSCalendar currentCalendar] dateByAddingComponents:comp 
                                                                    toDate:today 
                                                                   options:0];
    if ([self compare: before] == NSOrderedDescending) {
        if ( [self compare:today] == NSOrderedAscending ) {
            return YES;
        }
    }
    return NO;
}


-(BOOL) dayOccuredDuringLast7Days
{
    return [self _occuredDaysBeforeToday:7];
}

-(BOOL) dayWasYesterday
{
    return [self _occuredDaysBeforeToday:1];
}


@end



int main(int argc, const char * argv[])
{

    @autoreleasepool {

        NSDate *now =[NSDate date];
        NSDate *twoDaysBefore = [[NSCalendar currentCalendar] dateByAddingComponents:(
                                                                                      {
                                                                                          NSDateComponents *comps = [[NSDateComponents alloc] init];
                                                                                          comps.day = -2;
                                                                                          comps;
                                                                                      })
                                                                              toDate:now
                                                                             options:0];

        if ([twoDaysBefore dayOccuredDuringLast7Days]) {
            NSLog(@"last week");
        } else {
            NSLog(@"not last week");
        }

        if ([twoDaysBefore dayWasYesterday]) {
            NSLog(@"yesteday");
        } else {
            NSLog(@"not yesterday");
        }


    }
    return 0;
}
于 2014-04-13T23:55:08.480 に答える