2

次のメソッドのテストを書きたいと思います。このメソッドでは、最初にモックしたいメソッド呼び出しがさらに 2 つ行われます。最初は getterToMock() で、2 つ目はstaticメソッド呼び出しstaticです。Mockito ではメソッドをモックすることは不可能であるため、PowerMock を使用しましたが、私はまだ取得中ですNullPointerException

@Resource
private Bar bar;

public int methodToTest(String arg1) {
    String crucialValue = SomeClass.methodToMock(bar.getterToMock());
        Method Logic Here 
        ....
}

私のテストは次のようになります

private BarContext barContext = mock(BarContext.class)
@Mock
private Bar bar;

@Test
public void testTheMethod(){
    PowerMockito.mockStatic(SomeClass.class);
    PowerMockito.doReturn(barContext).when(bar).getterToMock();
    PowerMockito.doReturn("Bingo").when(SomeClass.methodToMock(barContext));
    Foo foo = new Foo();
    foo.methodToTest("foo");
}

問題は、 @Resource アノテーション付きプロパティを正しくモックしていないことだと思います

編集実際のコードを追加する

@WebService
public class FileUploadServiceImpl implements FileUploadService {

private final String soapFilePath = "target/;
private final static Map<String, String> userFileMap = new HashMap<>();
private final static AtomicInteger id = new AtomicInteger();

@Resource
private WebServiceContext webServiceContext;

@Override
public int createFile(@WebParam String name) {
    String username = Utils.getUsername(webServiceContext.getMessageContext());

    try {
        File userDir = new File(filePath + username);
        userDir.mkdir();
        File file = new File(userDir.getPath() + "/" + name);
        file.createNewFile();
        userFileMap.put(username + "_" + id.get(), name);
    } catch (IOException e) {
        LOG.error(e.getMessage(), e);
        e.printStackTrace();
    }
    return id.getAndIncrement();
   }
}

Utils クラスの getUsername

public static String getUsername(MessageContext context){
            Map httpHeaders = (Map) context.get(MessageContext.HTTP_REQUEST_HEADERS);
            if(httpHeaders != null){
                List<String> auth = (List<String>) httpHeaders.get("Authorization");
                if (auth != null && auth.get(0).startsWith("Basic")){
                    String base64Credentials = auth.get(0).substring("Basic".length()).trim();
                    String credentials = new String(Base64.getDecoder().decode(
                            base64Credentials.getBytes(Charset.forName("UTF-8"))));
                    return credentials.split(":", 2)[0];
                }
            }
        return null;
      }

テスト

@RunWith(PowerMockRunner.class)
@PrepareForTest(FileUploadServiceImpl.class)
public class ServiceTest {
private String username = "10237832";
private FileUploadService service;
private MessageContext messageContext = mock(MessageContext.class);

@Mock
private WebServiceContext webServiceContext;

@Test
public void startUploadFileTest(){
    service = new FileUploadServiceImpl();
    mockStatic(Utils.class);
    when(webServiceContext.getMessageContext()).thenReturn(messageContext);
    when(Utils.getUsername(messageContext)).thenReturn(username);
    service.startUpload("test_file");
  }
}

例外スタック トレース

java.lang.NullPointerException
    at org.example.utils.Utils.getUsername(Utils.java:47)
    at org.example.services.ServiceTest.startUploadFileTest(ServiceTest.java:42)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at org.junit.internal.runners.TestMethod.invoke(TestMethod.java:68)
    at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.runTestMethod(PowerMockJUnit44RunnerDelegateImpl.java:310)
    at org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:88)
    at org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:96)
    at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.executeTest(PowerMockJUnit44RunnerDelegateImpl.java:294)
    at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.executeTestInSuper(PowerMockJUnit47RunnerDelegateImpl.java:127)
    at org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.executeTest(PowerMockJUnit47RunnerDelegateImpl.java:82)
    at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.runBeforesThenTestThenAfters(PowerMockJUnit44RunnerDelegateImpl.java:282)
    at org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:86)
    at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:49)
    at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl.invokeTestMethod(PowerMockJUnit44RunnerDelegateImpl.java:207)
    at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl.runMethods(PowerMockJUnit44RunnerDelegateImpl.java:146)
    at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$1.run(PowerMockJUnit44RunnerDelegateImpl.java:120)
    at org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:33)
    at org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:45)
    at org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl.run(PowerMockJUnit44RunnerDelegateImpl.java:122)
    at org.powermock.modules.junit4.common.internal.impl.JUnit4TestSuiteChunkerImpl.run(JUnit4TestSuiteChunkerImpl.java:106)
    at org.powermock.modules.junit4.common.internal.impl.AbstractCommonPowerMockRunner.run(AbstractCommonPowerMockRunner.java:53)
    at org.powermock.modules.junit4.PowerMockRunner.run(PowerMockRunner.java:59)
    at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
    at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:78)
    at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:212)
    at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:68)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at com.intellij.rt.execution.application.AppMain.main(AppMain.java:140)
4

1 に答える 1

0

ユーザー名の取得をクラスに抽象化しないのはなぜですか?

    class UsernameRetriever {

        private final WebServiceContext webServiceContext;

        UsernameRetriever(WebServiceContext webServiceContext) {
           this.webServiceContext = webServiceContext;
        }


        String getUsernameFromContext() {
            return Utils.getUsername(webServiceContext.getMessageContext());
        }

    }

そして、コンストラクターを介してこれをクラスに注入します（ @Inject とコンストラクターの構文を覚えていないので、自分で確認してください）。

@WebService
public class FileUploadServiceImpl implements FileUploadService {

// SHOULD BE STATIC FINAL IF IT'S A CONSTANT - IT SHOULD BE PARAMETRIZED BTW
private static final String soapFilePath = "target/;
// YOU'RE GOING TO HAVE A RACE CONDITION - HASH MAP IS NOT THREAD SAFE
private final static Map<String, String> userFileMap = new HashMap<>();
private final static AtomicInteger id = new AtomicInteger();

private final UsernameRetriver usernameRetriever;

@Inject
public FileUploadServiceImpl(WebServiceContext webServiceContext) {
    this.usernameRetriever = new UsernameRetriever(webServiceContext);
}


@Inject
// for testing purposes
FileUploadServiceImpl(UsernameRetriever usernameRetriever) {
    this.usernameRetriever = usernameRetriever
}

@Override
public int createFile(@WebParam String name) {
    String username = usernameRetriever.getUsernameFromContext();

    try {
        File userDir = new File(filePath + username);
        userDir.mkdir();
        File file = new File(userDir.getPath() + "/" + name);
        file.createNewFile();
        userFileMap.put(username + "_" + id.get(), name);
    } catch (IOException e) {
        LOG.error(e.getMessage(), e);
        e.printStackTrace();
    }
    return id.getAndIncrement();
   }
}

その方法: * Powermock は必要ありません * 単一の責任があります * 適切にコードを記述しました ;)

ところで: * あなたのコードはスレッド セーフではありません - 本番環境では失敗します * パラメータ化できません (パス 'target' は固定されています)

于 2015-09-12T09:16:24.177 に答える