1

ユーザーがを選択するListViewItemと、その行の背景画像が変更されます。これは非常にゆっくりと起こるようです。理由がわかりませんか?

OnItemClickListener

listView.setOnItemClickListener(new OnItemClickListener() {
            @Override
            public void onItemClick(AdapterView<?> a, View v, int position, long id) {
                //quotesAdapter.setSelectedPosition(position);
                setupDetailView(position);
                setupChartView(position);
                setupARView(position);
                emptyView.setVisibility(View.INVISIBLE);

                ViewGroup vg = (ViewGroup)v;

                TextView nameText = (TextView) vg.findViewById(R.id.nameText);
                TextView priceText = (TextView) vg.findViewById(R.id.priceText);
                TextView changeText = (TextView) vg.findViewById(R.id.changeText);

                //change the old row back to normal
                if(oldView != null){
                    oldView.setBackgroundResource(R.drawable.stocks_gradient);
                    nameText.setTextAppearance(getApplicationContext(), R.style.BlueText);
                    priceText.setTextAppearance(getApplicationContext(), R.style.BlueText);
                    changeText.setTextAppearance(getApplicationContext(), R.style.BlueText);
                }

                //change the selected row
                v.setBackgroundResource(R.drawable.stocks_selected_gradient);
                nameText.setTextColor(Color.WHITE);
                priceText.setTextColor(Color.WHITE);
                changeText.setTextColor(Color.WHITE);

                //keep a reference to the old row, for the next time user clicks
                oldView = v;
            }
        });
    }

元のコード:

private class QuoteAdapter extends ArrayAdapter<Quote> {

        private ArrayList<Quote> items;
        // used to keep selected position in ListView
        private int selectedPos = -1; // init value for not-selected

        public QuoteAdapter(Context context, int textViewResourceId, ArrayList<Quote> items) {
            super(context, textViewResourceId, items);
            this.items = items;
        }

        public void setSelectedPosition(int pos) {
            selectedPos = pos;
            // inform the view of this change
            notifyDataSetChanged();
        }

        @Override
        public View getView(int position, View convertView, ViewGroup parent) {
            View v = convertView;
            if (v == null) {
                LayoutInflater vi = (LayoutInflater) getSystemService(Context.LAYOUT_INFLATER_SERVICE);
                v = vi.inflate(R.layout.mainrow, null);
            }

            TextView nameText = (TextView) v.findViewById(R.id.nameText);
            TextView priceText = (TextView) v.findViewById(R.id.priceText);
            TextView changeText = (TextView) v.findViewById(R.id.changeText);

            // change the row color based on selected state
            if (selectedPos == position) {
                v.setBackgroundResource(R.drawable.stocks_selected_gradient);
                nameText.setTextColor(Color.WHITE);
                priceText.setTextColor(Color.WHITE);
                changeText.setTextColor(Color.WHITE);
            } else {
                v.setBackgroundResource(R.drawable.stocks_gradient);
                nameText.setTextAppearance(getApplicationContext(), R.style.BlueText);
                priceText.setTextAppearance(getApplicationContext(), R.style.BlueText);
                changeText.setTextAppearance(getApplicationContext(), R.style.BlueText);
            }

            Quote q = items.get(position);
            if (q != null) {
                if (nameText != null) {
                    nameText.setText(q.getSymbol());
                }
                if (priceText != null) {
                    priceText.setText(q.getLastTradePriceOnly());
                }
                if (changeText != null) {
                    try {
                        float floatedChange = Float.valueOf(q.getChange());
                        if (floatedChange < 0) {
                            if (selectedPos != position)
                                changeText.setTextAppearance(getApplicationContext(), R.style.RedText); // red
                        } else {
                            if (selectedPos != position)
                                changeText.setTextAppearance(getApplicationContext(), R.style.GreenText); // green
                        }
                    } catch (NumberFormatException e) {
                        System.out.println("not a number");
                    } catch (NullPointerException e) {
                        System.out.println("null number");
                    }
                    changeText.setText(q.getChange() + " (" + q.getPercentChange() + ")");
                }
            }
            return v;
        }
    }

更新:ViewHolderパターンのアダプター

   private class QuoteAdapter extends ArrayAdapter<Quote> {

        private ArrayList<Quote> items;
        // used to keep selected position in ListView
        private int selectedPos = -1; // init value for not-selected

        public QuoteAdapter(Context context, int textViewResourceId, ArrayList<Quote> items) {
            super(context, textViewResourceId, items);
            this.items = items;
        }

        public void setSelectedPosition(int pos) {
            selectedPos = pos;
            // inform the view of this change
            notifyDataSetChanged();
        }

        @Override
        public View getView(int position, View convertView, ViewGroup parent) {
            View v = convertView;
            ViewHolder holder; // to reference the child views for later actions

            if (v == null) {
                LayoutInflater vi = (LayoutInflater)getSystemService(Context.LAYOUT_INFLATER_SERVICE);
                v = vi.inflate(R.layout.mainrow, null);

                // cache view fields into the holder
                holder = new ViewHolder();
                holder.nameText = (TextView) v.findViewById(R.id.nameText);
                holder.priceText = (TextView) v.findViewById(R.id.priceText);
                holder.changeText = (TextView) v.findViewById(R.id.changeText);

                // associate the holder with the view for later lookup
                v.setTag(holder);
            }
            else {
                // view already exists, get the holder instance from the view
                holder = (ViewHolder)v.getTag();
            }

            // change the row color based on selected state
            if (selectedPos == position) {
                v.setBackgroundResource(R.drawable.stocks_selected_gradient);
                holder.nameText.setTextColor(Color.WHITE);
                holder.priceText.setTextColor(Color.WHITE);
                holder.changeText.setTextColor(Color.WHITE);
            } else {
                v.setBackgroundResource(R.drawable.stocks_gradient);
                holder.nameText.setTextAppearance(getApplicationContext(), R.style.BlueText);
                holder.priceText.setTextAppearance(getApplicationContext(), R.style.BlueText);
                holder.changeText.setTextAppearance(getApplicationContext(), R.style.BlueText);
            }

            Quote q = items.get(position);
            if (q != null) {
                if (holder.nameText != null) {
                    holder.nameText.setText(q.getSymbol());
                }
                if (holder.priceText != null) {
                    holder.priceText.setText(q.getLastTradePriceOnly());
                }
                if (holder.changeText != null) {
                    try {
                        float floatedChange = Float.valueOf(q.getChange());
                        if (floatedChange < 0) {
                            if (selectedPos != position)
                                holder.changeText.setTextAppearance(getApplicationContext(), R.style.RedText); // red
                        } else {
                            if (selectedPos != position)
                                holder.changeText.setTextAppearance(getApplicationContext(), R.style.GreenText); // green
                        }
                    } catch (NumberFormatException e) {
                        System.out.println("not a number");
                    } catch (NullPointerException e) {
                        System.out.println("null number");
                    }
                    holder.changeText.setText(q.getChange() + " (" + q.getPercentChange() + ")");
                }
            }
            return v;
        }
    }
4

2 に答える 2

1

あなたgetView()は大丈夫です(それはより速くすることができますが)。問題はにあると思いますsetSelectedPosition()。notifyDataSetChanged()を呼び出しているため、再描画されるビューが多すぎます。ステートフルドローアブルで選択の背景を処理する必要があります。

于 2010-09-30T06:10:04.007 に答える
0

データセットの大きさも、一度に画面に表示される要素の数もわかりませんが、リストが単一選択モードであり、正しい状態でステートフルドローアブルを使用できることを保証できる場合は、別の色を持っている

<selector xmlns:android="http://schemas.android.com/apk/res/android"
    android:dither="true" >
    <item
        android:state_pressed="true"
        android:state_enabled="true"
        android:drawable="@color/my_color" />

    <item
        android:state_selected="true"
        android:drawable="@color/my_color" />
    </item>

    <item
        android:state_focused="true"
        android:state_enabled="true"
        android:drawable="@android:drawable/list_selector_background" />
</selector>

これは自動的に機能するはずです。

listView選択した状態を粘着性があるように見せたい場合は、複数選択を行い、呼び出しをインターセプトして、選択を設定して前の状態を設定解除してみることもできます。

手動でも背景を設定したい場合は、他の人が使用しているパターンをgetView使用してメソッドを最適化します。ViewHolderこれにより、再描画の費用が安くなり、実際には発生しなかったかのように見えます(これも、その時点で画面に表示されていた要素の数によって異なります)。

http://developer.android.com/resources/samples/ApiDemos/src/com/example/android/apis/view/List14.html

于 2010-09-30T07:25:31.393 に答える