2

編集: 修正のために arc4random() を arc4random_uniform() に置き換えました

テストフライトを使用してクラッシュを監視しています。バグを修正していましたが、このバグに遭遇しました。インデックスがなぜそんなに大きいのかわかりません。

 -[__NSArrayM objectAtIndex:]: index 4294967295 beyond bounds for empty array

これがバグの場所である可能性が高い

for (NSUInteger i = 0; i < count; ++i) {
        // Select a random element between i and end of array to swap with.
        int nElements = count - i;
        int n = (arc4random() % nElements) + i;
        [randomName exchangeObjectAtIndex:i withObjectAtIndex:n];
        [randomImgName exchangeObjectAtIndex:i withObjectAtIndex:n];
        [randomID exchangeObjectAtIndex:i withObjectAtIndex:n];
    }

ここでクラッシュを引き起こした

//Frog Name Caption
    NSString * tempCaption = [defaultFrogImageCaption objectAtIndex:[defaultFrogImageCaption count]-1];
    self.dFrogID = [defaultFrogID objectAtIndex:[defaultFrogID count]-1];

これはバグだと思いますが、エラーを解決する方法がわかりません。

すべてのコメントとヘルプに感謝

-(void)defaultFrogSetup
{
self.imageArray = [[NSMutableArray alloc] initWithObjects:
                       [UIImage imageWithContentsOfFile:[[[NSBundle mainBundle] resourcePath] stringByAppendingPathComponent:@"defaultFrog/d7.jpg"]],
                       [UIImage imageWithContentsOfFile:[[[NSBundle mainBundle] resourcePath] stringByAppendingPathComponent:@"defaultFrog/d9.jpg"]],
                       [UIImage imageWithContentsOfFile:[[[NSBundle mainBundle] resourcePath] stringByAppendingPathComponent:@"defaultFrog/d11.jpg"]],
                       [UIImage imageWithContentsOfFile:[[[NSBundle mainBundle] resourcePath] stringByAppendingPathComponent:@"defaultFrog/d27.jpg"]],
                       [UIImage imageWithContentsOfFile:[[[NSBundle mainBundle] resourcePath] stringByAppendingPathComponent:@"defaultFrog/d6.jpg"]],                        
                       nil];

    //self.defaultFrogID = [[NSMutableArray alloc] initWithObjects:@"6",@"8",@"10",@"26",@"5",nil];
    self.defaultFrogID = [[NSMutableArray alloc] initWithObjects:@"6",@"8",@"10",@"24",@"5",nil];
    self.defaultFrogImageCaption = [[NSMutableArray alloc] initWithObjects:@"Verreaux's Tree Frog",@"Green Tree Frog",@"Red-Eyed Tree Frog",@"Crucifix Frog",@"Eastern Dwarf Tree Frog",nil];    

    NSUInteger count = [self.defaultFrogID count];
    //NSLog(@"Count %i",[self.defaultFrogID count]);
    NSMutableArray *randomImgName = self.imageArray;
    NSMutableArray *randomID = self.defaultFrogID;
    NSMutableArray *randomName = self.defaultFrogImageCaption;

    //likely bug here
    for (NSUInteger i = 0; i < count; ++i) {
        // Select a random element between i and end of array to swap with.
        int nElements = count - i;
        int n = (arc4random() % nElements) + i;
        [randomName exchangeObjectAtIndex:i withObjectAtIndex:n];
        [randomImgName exchangeObjectAtIndex:i withObjectAtIndex:n];
        [randomID exchangeObjectAtIndex:i withObjectAtIndex:n];
    }
    self.imageArray = randomImgName;
    self.defaultFrogID=randomID;
    self.defaultFrogImageCaption=randomName;

    //NSLog(@"default filename %@",self.defaultFrogImageCaption);
    //NSLog(@"default frog ID %@",self.defaultFrogID);

    self.imageViewTop.alpha = 1.0;
    self.imageViewBottom.alpha = 0.0;
    self.imageViewBottom = [[UIImageView alloc] initWithFrame:CGRectMake(0,44,320,367)];
    self.imageViewTop = [[UIImageView alloc] initWithFrame:CGRectMake(0,44,320,367)];
    [self.view addSubview:imageViewTop];
    [self.view addSubview:imageViewBottom];
    self.buttonCaption = [UIButton buttonWithType:UIButtonTypeCustom];
    //default placement
    self.buttonCaption.frame = CGRectMake(245, 367, 70, 44);
    //[buttonCaption setTitle:@"\u00A9"  forState:UIControlStateNormal];
    [self.buttonCaption addTarget:self action:@selector(buttonCheck) forControlEvents:UIControlEventTouchUpInside];
    [self.view addSubview:self.buttonCaption];
    [self defaultFrogAnimation:buttonCaption.frame.size.width];    

}

-(void)defaultFrogAnimation:(float)previousWidth {




    defaultFrog = 1;
    foundFrog = 0;

    //picture loop
    imageViewTop.image = imageViewBottom.image;
    imageViewBottom.image = [imageArray objectAtIndex:[imageArray count] - 1]; 
    [imageArray insertObject:imageViewBottom.image atIndex:0];
    [imageArray removeLastObject];
    imageViewTop.alpha = 1.0;
    imageViewBottom.alpha = 0.0;

    //Frog Name Caption
    NSString * tempCaption = [defaultFrogImageCaption objectAtIndex:[defaultFrogImageCaption count]-1];
    self.dFrogID = [defaultFrogID objectAtIndex:[defaultFrogID count]-1];

    // make the buttons content appear in the top-left
    [buttonCaption setContentHorizontalAlignment:UIControlContentHorizontalAlignmentCenter];
    [buttonCaption setContentVerticalAlignment: UIControlContentVerticalAlignmentCenter ];    

    [defaultFrogImageCaption insertObject:tempCaption atIndex:0];
    [defaultFrogImageCaption removeLastObject];
    [defaultFrogID insertObject:dFrogID atIndex:0];
    [defaultFrogID removeLastObject];

    //button setting

    [buttonCaption.titleLabel setAutoresizingMask:UIViewAutoresizingFlexibleWidth];
    [buttonCaption.titleLabel setFont:[UIFont systemFontOfSize:17]];
    [buttonCaption setTitleColor:[UIColor blackColor] forState:UIControlStateNormal];

    [[buttonCaption layer] setCornerRadius:5.0f];
    [[buttonCaption layer] setMasksToBounds:YES];
    [[buttonCaption layer] setBackgroundColor:[[UIColor colorWithRed:255 green:255 blue:255 alpha:1] CGColor]];   
    [buttonCaption.titleLabel setFrame:CGRectMake(0,9, 25, 25)];
    stringsize = [tempCaption sizeWithFont:[UIFont systemFontOfSize:19]];  
    CGFloat diff = stringsize.width - previousWidth;
    //NSLog(@"diff %f",diff);

    [UIView animateWithDuration:3

                     animations:^{ 
                         imageViewTop.alpha = 0.0;
                         imageViewBottom.alpha = 1.0;
                     } 
                     completion:^(BOOL  completed){
                         if (completed)        
                             [self defaultFrogAnimation:stringsize.width];                  
                     }                      

     ];    

    [UIView animateWithDuration:0.1 delay:0 options:0       
                     animations:^{                          
                         [buttonCaption setTitle:tempCaption   forState:UIControlStateNormal];

                         NSLog(@"frog Name %@",tempCaption );
                         NSLog(@"frog ID %@",dFrogID);
                     } 
                     completion:^(BOOL  completed)
     {
     }];     

    [UIView animateWithDuration:0.3 delay:0 options:0       
                     animations:^{ 
                         [buttonCaption setFrame:CGRectMake(buttonCaption.frame.origin.x-diff, 
                                                            buttonCaption.frame.origin.y, 
                                                            buttonCaption.frame.size.width + diff, 
                                                            buttonCaption.frame.size.height)];                         
                     } 
                     completion:^(BOOL  completed){
                     }];  
}
4

2 に答える 2

19

配列のサイズはゼロです。大きな数は、実際には符号なし整数として表される -1 です。[array count]-1 を評価すると、配列のサイズが 0 であるため、インデックス -1 のオブジェクトにアクセスしようとします。宣言時にretainなどを指定しなかったため、配列defaultFrogIdまたはdefaultFrogIdCaptionが空であると思われます。

于 2012-01-20T04:43:34.330 に答える
1

あなたがそれを修正した方法は大丈夫です。ただし、iOS 4.3 以降でのみ動作します... 問題を解決するには、abs(arc4random())%mod_factor代わりにarc4random()%mod_factor. 問題は、arc4random()符号なし整数値を返すという事実によるものです。

于 2012-03-02T06:18:46.187 に答える